fix

backend/gestion/db/db_notifications.go

@@ -33,12 +33,20 @@ func (d *Database) NotifyClient(username string, commandID int, notifType, messa
 	}
 
 	notifJSON, _ := json.Marshal(notification)
-	Redis.LPush(RedisCtx, notifKey, notifJSON)
-	Redis.Expire(RedisCtx, notifKey, 7*24*time.Hour)
+	pipe := Redis.Pipeline()
+	pipe.LPush(RedisCtx, notifKey, notifJSON)
+	pipe.LTrim(RedisCtx, notifKey, 0, 199)
+	pipe.Expire(RedisCtx, notifKey, 7*24*time.Hour)
+	pipe.Exec(RedisCtx) //nolint
 
 	if services.TelegramBot != nil && services.TelegramBot.IsNotificationsEnabled() {
 		if chatID, ok, err := d.GetClientTelegramChatID(username); err == nil && ok {
-			go sendTelegramNotif(chatID, fmt.Sprintf("🔔 <b>Notification</b>\n\n%s", message))
+			dedupKey := fmt.Sprintf("notif:dedup:%d:%s", commandID, notifType)
+			if set, _ := Redis.SetNX(RedisCtx, dedupKey, "1", 5*time.Minute).Result(); set {
+				go sendTelegramNotif(chatID, fmt.Sprintf("🔔 <b>Notification</b>\n\n%s", message))
+			} else {
+				log.Printf("⚠️ [NOTIF] Doublon détecté (cmd=%d, type=%s) — Telegram ignoré", commandID, notifType)
+			}
 		}
 	}
 
@@ -46,7 +54,6 @@ func (d *Database) NotifyClient(username string, commandID int, notifType, messa
 	return nil
 }
 
-// NotifyLivreur envoie une notification in-app (Redis) à un livreur
 func (d *Database) NotifyLivreur(username string, commandID int, notifType, message string) error {
 	notifKey := fmt.Sprintf("notifications:%s", username)
 
@@ -59,12 +66,20 @@ func (d *Database) NotifyLivreur(username string, commandID int, notifType, mess
 	}
 
 	notifJSON, _ := json.Marshal(notification)
-	Redis.LPush(RedisCtx, notifKey, notifJSON)
-	Redis.Expire(RedisCtx, notifKey, 7*24*time.Hour)
+	pipe2 := Redis.Pipeline()
+	pipe2.LPush(RedisCtx, notifKey, notifJSON)
+	pipe2.LTrim(RedisCtx, notifKey, 0, 199)
+	pipe2.Expire(RedisCtx, notifKey, 7*24*time.Hour)
+	pipe2.Exec(RedisCtx) //nolint
 
 	if services.TelegramBot != nil && services.TelegramBot.IsNotificationsEnabled() {
 		if chatID, ok, err := d.GetUserTelegramChatID(username); err == nil && ok {
-			go sendTelegramNotif(chatID, fmt.Sprintf("🔔 <b>Notification</b>\n\n%s", message))
+			dedupKey := fmt.Sprintf("notif:dedup:livreur:%d:%s", commandID, notifType)
+			if set, _ := Redis.SetNX(RedisCtx, dedupKey, "1", 5*time.Minute).Result(); set {
+				go sendTelegramNotif(chatID, fmt.Sprintf("🔔 <b>Notification</b>\n\n%s", message))
+			} else {
+				log.Printf("⚠️ [NOTIF] Doublon livreur détecté (cmd=%d, type=%s) — Telegram ignoré", commandID, notifType)
+			}
 		}
 	}
 
@@ -72,7 +87,6 @@ func (d *Database) NotifyLivreur(username string, commandID int, notifType, mess
 	return nil
 }
 
-// NotifyAllAdminCabine stocke une notification Redis pour tous les admins/cabines
 func (d *Database) NotifyAllAdminCabine(commandID int, clientUsername, deliveryAddr string) {
 	var users []struct {
 		Username string `gorm:"column:username"`
@@ -93,24 +107,27 @@ func (d *Database) NotifyAllAdminCabine(commandID int, clientUsername, deliveryA
 	}
 	notifJSON, _ := json.Marshal(notification)
 
-	count := 0
+	pipe := Redis.Pipeline()
 	for _, u := range users {
 		notifKey := fmt.Sprintf("notifications:%s", u.Username)
-		Redis.LPush(RedisCtx, notifKey, notifJSON)
-		Redis.Expire(RedisCtx, notifKey, 7*24*time.Hour)
+		pipe.LPush(RedisCtx, notifKey, notifJSON)
+		pipe.LTrim(RedisCtx, notifKey, 0, 199)
+		pipe.Expire(RedisCtx, notifKey, 7*24*time.Hour)
+	}
+	pipe.Exec(RedisCtx) //nolint
 
-		if services.TelegramBot != nil && services.TelegramBot.IsNotificationsEnabled() {
+	count := len(users)
+	if services.TelegramBot != nil && services.TelegramBot.IsNotificationsEnabled() {
+		for _, u := range users {
 			if chatID, ok, err := d.GetUserTelegramChatID(u.Username); err == nil && ok {
 				capturedChatID := chatID
 				go sendTelegramNotif(capturedChatID, fmt.Sprintf("🔔 <b>Nouvelle commande</b>\n\n%s", msg))
 			}
 		}
-		count++
 	}
 	log.Printf("📬 [ADMIN_NOTIF] Notif Redis (%d users) pour commande #%d", count, commandID)
 }
 
-// NotifyAllAdminCabineAlert envoie une notification Redis à tous les admins/cabines lors d'une alerte
 func (d *Database) NotifyAllAdminCabineAlert(alertID int, livreurUsername, alertMessage string) {
 	var users []struct {
 		Username string `gorm:"column:username"`
@@ -131,19 +148,23 @@ func (d *Database) NotifyAllAdminCabineAlert(alertID int, livreurUsername, alert
 	}
 	notifJSON, _ := json.Marshal(notification)
 
-	count := 0
+	pipe := Redis.Pipeline()
 	for _, u := range users {
 		notifKey := fmt.Sprintf("notifications:%s", u.Username)
-		Redis.LPush(RedisCtx, notifKey, notifJSON)
-		Redis.Expire(RedisCtx, notifKey, 7*24*time.Hour)
+		pipe.LPush(RedisCtx, notifKey, notifJSON)
+		pipe.LTrim(RedisCtx, notifKey, 0, 199)
+		pipe.Expire(RedisCtx, notifKey, 7*24*time.Hour)
+	}
+	pipe.Exec(RedisCtx) //nolint
 
-		if services.TelegramBot != nil && services.TelegramBot.IsNotificationsEnabled() {
+	count := len(users)
+	if services.TelegramBot != nil && services.TelegramBot.IsNotificationsEnabled() {
+		for _, u := range users {
 			if chatID, ok, err := d.GetUserTelegramChatID(u.Username); err == nil && ok {
 				capturedChatID := chatID
 				go sendTelegramNotif(capturedChatID, fmt.Sprintf("🚨 <b>Alerte livreur</b>\n\n%s", body))
 			}
 		}
-		count++
 	}
 	log.Printf("🚨 [ALERT_NOTIF] Notif Redis (%d users) pour alerte #%d de %s", count, alertID, livreurUsername)
 }